Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block: Fix error code for bdrv_getlength when the image is too big

[Markus Armbruster]

Fam Zheng <address@hidden> writes:

> v2: Correct detection of overflow. [Markus, Berto]
>
> If the image has a huge enough virtual size,
>
>   $ qemu-img info afl9.img
>   qemu-img: Can't get size of device 'image': Unknown error -512
>
> It's because of the multiplication overflow in the return statement in
> bdrv_getlength (the big nagetive value is later truncated to 0x200). Fix it to
> return -EFBIG:
>
>   qemu-img: Can't get size of device 'image': File too large
>
> Bug reported by Richard Jones in:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1221499

Series
Reviewed-by: Markus Armbruster <address@hidden>