[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 03/11] block: rename BlkTransactionState and
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v4 03/11] block: rename BlkTransactionState and BdrvActionOps |
Date: |
Mon, 18 May 2015 13:24:43 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, May 11, 2015 at 07:04:18PM -0400, John Snow wrote:
> These structures are misnomers, somewhat.
>
> (1) BlockTransactionState is not state for a transaction,
> but is rather state for a single transaction action.
> Rename it "BlkActionState" to be more accurate.
>
> (2) The BdrvActionOps describes operations for the BlkActionState,
> above. This name might imply a 'BdrvAction' or a 'BdrvActionState',
> which there isn't.
> Rename this to 'BlkActionOps' to match 'BlkActionState'.
>
> Lastly, update the surrounding in-line documentation and comments
> to reflect the current nature of how Transactions operate.
>
> This patch changes only comments and names, and should not affect
> behavior in any way.
>
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> blockdev.c | 116
> ++++++++++++++++++++++++++++++++++---------------------------
> 1 file changed, 65 insertions(+), 51 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpZZxYU9oWbK.pgp
Description: PGP signature
- [Qemu-block] [PATCH v4 00/11] block: incremental backup transactions, John Snow, 2015/05/11
- [Qemu-block] [PATCH v4 02/11] iotests: add transactional incremental backup test, John Snow, 2015/05/11
- [Qemu-block] [PATCH v4 04/11] block: re-add BlkTransactionState, John Snow, 2015/05/11
- [Qemu-block] [PATCH v4 01/11] qapi: Add transaction support to block-dirty-bitmap operations, John Snow, 2015/05/11
- [Qemu-block] [PATCH v4 03/11] block: rename BlkTransactionState and BdrvActionOps, John Snow, 2015/05/11
- Re: [Qemu-block] [PATCH v4 03/11] block: rename BlkTransactionState and BdrvActionOps,
Stefan Hajnoczi <=
- [Qemu-block] [PATCH v4 05/11] block: add transactional callbacks feature, John Snow, 2015/05/11
- [Qemu-block] [PATCH v4 06/11] block: add refcount to Job object, John Snow, 2015/05/11
[Qemu-block] [PATCH v4 07/11] block: add delayed bitmap successor cleanup, John Snow, 2015/05/11
[Qemu-block] [PATCH v4 08/11] qmp: Add an implementation wrapper for qmp_drive_backup, John Snow, 2015/05/11