qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v4 03/11] block: rename BlkTransactionState and


From: Stefan Hajnoczi
Subject: Re: [Qemu-block] [PATCH v4 03/11] block: rename BlkTransactionState and BdrvActionOps
Date: Mon, 18 May 2015 13:24:43 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, May 11, 2015 at 07:04:18PM -0400, John Snow wrote:
> These structures are misnomers, somewhat.
> 
> (1) BlockTransactionState is not state for a transaction,
>     but is rather state for a single transaction action.
>     Rename it "BlkActionState" to be more accurate.
> 
> (2) The BdrvActionOps describes operations for the BlkActionState,
>     above. This name might imply a 'BdrvAction' or a 'BdrvActionState',
>     which there isn't.
>     Rename this to 'BlkActionOps' to match 'BlkActionState'.
> 
> Lastly, update the surrounding in-line documentation and comments
> to reflect the current nature of how Transactions operate.
> 
> This patch changes only comments and names, and should not affect
> behavior in any way.
> 
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
>  blockdev.c | 116 
> ++++++++++++++++++++++++++++++++++---------------------------
>  1 file changed, 65 insertions(+), 51 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: pgpZZxYU9oWbK.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]