qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] floppy: fix I/O ranges in both portio and acpi


From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH] floppy: fix I/O ranges in both portio and acpi dsdt
Date: Thu, 28 May 2015 18:36:40 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 28.05.2015 um 17:37 hat Gerd Hoffmann geschrieben:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  hw/block/fdc.c            | 2 +-
>  hw/i386/acpi-dsdt-isa.dsl | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

The commit message could be a bit longer, I don't think this change is
obvious.

My FDC spec says that this version of the controller doesn't have the
SRA register any more, and the emulation was added in the context of a
Sun4m patch (commit 8c6a4d774). Therefore my default assumption would be
that it's intentionally not accessible and not needed on isa-fdc.

I'm happy to get that assumption corrected, but it needs a non-empty
commit message for that.

Kevin


> diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> index d8a8edd..c761291 100644
> --- a/hw/block/fdc.c
> +++ b/hw/block/fdc.c
> @@ -2186,7 +2186,7 @@ static void fdctrl_realize_common(FDCtrl *fdctrl, Error 
> **errp)
>  }
>  
>  static const MemoryRegionPortio fdc_portio_list[] = {
> -    { 1, 5, 1, .read = fdctrl_read, .write = fdctrl_write },
> +    { 0, 6, 1, .read = fdctrl_read, .write = fdctrl_write },
>      { 7, 1, 1, .read = fdctrl_read, .write = fdctrl_write },
>      PORTIO_END_OF_LIST(),
>  };
> diff --git a/hw/i386/acpi-dsdt-isa.dsl b/hw/i386/acpi-dsdt-isa.dsl
> index 89caa16..f71d7df 100644
> --- a/hw/i386/acpi-dsdt-isa.dsl
> +++ b/hw/i386/acpi-dsdt-isa.dsl
> @@ -58,7 +58,7 @@ Scope(\_SB.PCI0.ISA) {
>              }
>          }
>          Name(_CRS, ResourceTemplate() {
> -            IO(Decode16, 0x03F2, 0x03F2, 0x00, 0x04)
> +            IO(Decode16, 0x03F0, 0x03F0, 0x00, 0x06)
>              IO(Decode16, 0x03F7, 0x03F7, 0x00, 0x01)
>              IRQNoFlags() { 6 }
>              DMA(Compatibility, NotBusMaster, Transfer8) { 2 }
> -- 
> 1.8.3.1
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]