[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/3] qcow2: mark the memory as no longer needed
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty() |
|
Date: |
Tue, 02 Jun 2015 13:08:52 +0200 |
|
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Tue 02 Jun 2015 12:56:10 PM CEST, Kevin Wolf wrote:
>> > It seems that getpagesize() is usually used in qemu.
>>
>> The getpagesize() manual page actually recommends using sysconf() for
>> portability reasons. But other than that I don't have a problem with
>> getpagesize() if it's the preferred choice in QEMU.
>
> There is a Windows implementation for getpagesize() in qemu, so I
> guess it's actually more portable in our context.
Ok, I'll change that.
> Now, as you'll #ifdef this code out for Windows, that probably doesn't
> matter, so it's just about consistency.
There's actually no need to #ifdef that code out, I only do it because I
know in advance that it's going to be a no-op, but qemu_madvise() itself
doesn't break or anything if the operation is not supported.
Berto