[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: Fix .bdrv_co_get_block_
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size |
|
Date: |
Tue, 09 Jun 2015 05:36:44 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/09/2015 02:55 AM, Kevin Wolf wrote:
> Image files with an unaligned image size have a final hole that starts
> at EOF, i.e. in the middle of a sector. Currently, *pnum == 0 is
> returned when checking the status of this sector. In qemu-img, this
> triggers an assertion failure.
>
> In order to fix this, one type for the sector that contains EOF must be
> found. Treating a hole as data is safe, so this patch rounds the
> calculated number of data sectors up, so that a partial sector at EOF is
> treated as a full data sector.
>
> This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1229394
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/raw-posix.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature