[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 04/16] ahci: check for ncq prdtl overflow
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH 04/16] ahci: check for ncq prdtl overflow |
Date: |
Mon, 22 Jun 2015 15:06:19 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jun 19, 2015 at 09:50:35PM -0400, John Snow wrote:
> @@ -999,20 +1000,28 @@ static void process_ncq_command(AHCIState *s, int
> port, uint8_t *cmd_fis,
> ((uint64_t)ncq_fis->lba2 << 16) |
> ((uint64_t)ncq_fis->lba1 << 8) |
> (uint64_t)ncq_fis->lba0;
> + ncq_tfs->tag = tag;
>
> - /* Note: We calculate the sector count, but don't currently rely on it.
> - * The total size of the DMA buffer tells us the transfer size instead.
> */
> ncq_tfs->sector_count = ((uint16_t)ncq_fis->sector_count_high << 8) |
> ncq_fis->sector_count_low;
> + ahci_populate_sglist(ad, &ncq_tfs->sglist, 0);
> + size = ncq_tfs->sector_count * 512;
ncq_tfs->sector_count is used with - 2 and - 1 below. What is the
semantics of this field and why is it okay to use it without subtracting
here?
pgplV2f9P_kMK.pgp
Description: PGP signature
[Qemu-block] [PATCH 06/16] ahci: add ncq debug checks, John Snow, 2015/06/19
[Qemu-block] [PATCH 05/16] ahci: separate prdtl from opts, John Snow, 2015/06/19
[Qemu-block] [PATCH 08/16] ahci: clear error register before NCQ cmd, John Snow, 2015/06/19