[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH V2 2/5] virtio-blk: advertise scsi only when scs
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set |
|
Date: |
Wed, 15 Jul 2015 09:57:21 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 15/07/2015 07:29, Jason Wang wrote:
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: address@hidden
> Signed-off-by: Jason Wang <address@hidden>
> ---
> hw/block/virtio-blk.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> index 4c27974..761d763 100644
> --- a/hw/block/virtio-blk.c
> +++ b/hw/block/virtio-blk.c
> @@ -731,7 +731,9 @@ static uint64_t virtio_blk_get_features(VirtIODevice
> *vdev, uint64_t features,
> virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY);
> virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY);
> virtio_add_feature(&features, VIRTIO_BLK_F_BLK_SIZE);
> - virtio_add_feature(&features, VIRTIO_BLK_F_SCSI);
> + if (s->conf.scsi) {
> + virtio_add_feature(&features, VIRTIO_BLK_F_SCSI);
> + }
This must only be done for newer machine types only, or you change guest
ABI for scsi=off. Effectively you have to split it in two properties,
"scsi" and "always_set_f_scsi".
Paolo