Re: [Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor()

[Paolo Bonzini]

On 23/07/2015 13:08, Peter Maydell wrote:
> We have a qemu_fls() function which is just a silly wrapper
> around clz32() and which is used in only a handful of places
> in the codebase. It turns out that all of those are really
> trying to round up or down to a power of 2, which is something
> we have utility functions for. This series replaces all
> the qemu_fls() calls with pow2ceil() or pow2floor(), and then
> removes the now-unused function.
> 
> For the case where you really want to do bit counting rather
> than just power-of-2 rounding, you should use the clz/clo
> functions directly.
> 
> (I've set myself a little goal of "try to do one cleanup a
> day"; that may be a bit ambitious, so we'll see...)

If it turns out to be ambitious, even just "record one cleanup a day in
BiteSizedTasks" would be awesome.

Paolo