[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor()
From: |
Peter Maydell |
Subject: |
[Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor() |
Date: |
Thu, 23 Jul 2015 12:08:53 +0100 |
We have a qemu_fls() function which is just a silly wrapper
around clz32() and which is used in only a handful of places
in the codebase. It turns out that all of those are really
trying to round up or down to a power of 2, which is something
we have utility functions for. This series replaces all
the qemu_fls() calls with pow2ceil() or pow2floor(), and then
removes the now-unused function.
For the case where you really want to do bit counting rather
than just power-of-2 rounding, you should use the clz/clo
functions directly.
(I've set myself a little goal of "try to do one cleanup a
day"; that may be a bit ambitious, so we'll see...)
Peter Maydell (5):
hw/pci: Use pow2ceil() rather than hand-calculation
hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation
hw/block/nvme.c: Use pow2ceil() rather than hand-calculation
exec.c: Use pow2floor() rather than hand-calculation
Remove unused qemu_fls function
exec.c | 4 +---
hw/block/nvme.c | 2 +-
hw/pci/msix.c | 4 +---
hw/pci/pci.c | 4 +---
hw/virtio/virtio-pci.c | 4 +---
include/qemu-common.h | 1 -
util/cutils.c | 5 -----
7 files changed, 5 insertions(+), 19 deletions(-)
--
1.9.1
- [Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor(),
Peter Maydell <=
- [Qemu-block] [PATCH 3/5] hw/block/nvme.c: Use pow2ceil() rather than hand-calculation, Peter Maydell, 2015/07/23
- Re: [Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor(), Paolo Bonzini, 2015/07/23
- [Qemu-block] [PATCH 4/5] exec.c: Use pow2floor() rather than hand-calculation, Peter Maydell, 2015/07/23
- [Qemu-block] [PATCH 5/5] Remove unused qemu_fls function, Peter Maydell, 2015/07/23
- [Qemu-block] [PATCH 2/5] hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation, Peter Maydell, 2015/07/23
- [Qemu-block] [PATCH 1/5] hw/pci: Use pow2ceil() rather than hand-calculation, Peter Maydell, 2015/07/23
- Re: [Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor(), Paolo Bonzini, 2015/07/23