[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block: warn about aio=nativ
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable |
|
Date: |
Thu, 23 Jul 2015 13:06:12 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jul 23, 2015 at 10:03:32AM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi <address@hidden> writes:
>
> > v2:
> > * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business
> > [Kevin]
> > * Print the warning in the same way as the aio=native,cache.direct=off
> > deprecation warning [Kevin]
> >
> > Open question: what about the Windows case? We now pass the
> > FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native.
>
> Odd. Commit a273652 takes the trouble to implement native asynchronous
> I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's
> unreachable, isn't it? Paolo?
>
> I think PATCH 2's commit message needs to be updated to discuss the
> impact.
Nice find!
I'll send a v2.
pgpOAPxccPLb8.pgp
Description: PGP signature