[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 05/18] aio: tweak walking in dispatch phase
From: |
Paolo Bonzini |
Subject: |
[Qemu-block] [PATCH 05/18] aio: tweak walking in dispatch phase |
Date: |
Thu, 6 Aug 2015 15:36:03 +0200 |
Signed-off-by: Paolo Bonzini <address@hidden>
---
aio-posix.c | 26 ++++++++++++--------------
aio-win32.c | 26 ++++++++++++--------------
2 files changed, 24 insertions(+), 28 deletions(-)
diff --git a/aio-posix.c b/aio-posix.c
index d477033..b8aaa92 100644
--- a/aio-posix.c
+++ b/aio-posix.c
@@ -124,7 +124,7 @@ bool aio_pending(AioContext *ctx)
bool aio_dispatch(AioContext *ctx)
{
- AioHandler *node;
+ AioHandler *node, *tmp;
bool progress = false;
/*
@@ -140,12 +140,10 @@ bool aio_dispatch(AioContext *ctx)
* We have to walk very carefully in case aio_set_fd_handler is
* called while we're walking.
*/
- node = QLIST_FIRST(&ctx->aio_handlers);
- while (node) {
- AioHandler *tmp;
- int revents;
+ ctx->walking_handlers++;
- ctx->walking_handlers++;
+ QLIST_FOREACH_SAFE(node, &ctx->aio_handlers, node, tmp) {
+ int revents;
revents = node->pfd.revents & node->pfd.events;
node->pfd.revents = 0;
@@ -167,17 +165,17 @@ bool aio_dispatch(AioContext *ctx)
progress = true;
}
- tmp = node;
- node = QLIST_NEXT(node, node);
-
- ctx->walking_handlers--;
-
- if (!ctx->walking_handlers && tmp->deleted) {
- QLIST_REMOVE(tmp, node);
- g_free(tmp);
+ if (node->deleted) {
+ ctx->walking_handlers--;
+ if (!ctx->walking_handlers) {
+ g_free(node);
+ }
+ ctx->walking_handlers++;
}
}
+ ctx->walking_handlers--;
+
/* Run our timers */
progress |= timerlistgroup_run_timers(&ctx->tlg);
diff --git a/aio-win32.c b/aio-win32.c
index 50a6867..2b4b156 100644
--- a/aio-win32.c
+++ b/aio-win32.c
@@ -203,20 +203,18 @@ bool aio_pending(AioContext *ctx)
static bool aio_dispatch_handlers(AioContext *ctx, HANDLE event)
{
- AioHandler *node;
+ AioHandler *node, *tmp;
bool progress = false;
+ ctx->walking_handlers++;
+
/*
* We have to walk very carefully in case aio_set_fd_handler is
* called while we're walking.
*/
- node = QLIST_FIRST(&ctx->aio_handlers);
- while (node) {
- AioHandler *tmp;
+ QLIST_FOREACH_SAFE(node, &ctx->aio_handlers, node, tmp) {
int revents = node->pfd.revents;
- ctx->walking_handlers++;
-
if (!node->deleted &&
(revents || event_notifier_get_handle(node->e) == event) &&
node->io_notify) {
@@ -251,17 +249,17 @@ static bool aio_dispatch_handlers(AioContext *ctx, HANDLE
event)
}
}
- tmp = node;
- node = QLIST_NEXT(node, node);
-
- ctx->walking_handlers--;
-
- if (!ctx->walking_handlers && tmp->deleted) {
- QLIST_REMOVE(tmp, node);
- g_free(tmp);
+ if (node->deleted) {
+ ctx->walking_handlers--;
+ if (!ctx->walking_handlers) {
+ QLIST_REMOVE(tmp, node);
+ g_free(tmp);
+ }
+ ctx->walking_handlers++;
}
}
+ ctx->walking_handlers--;
return progress;
}
--
2.4.3
- [Qemu-block] [RFC PATCH 00/18] Fine-grained AioContext critical sections, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 02/18] aio: rename bh_lock to list_lock, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 03/18] qemu-thread: introduce QemuLockCnt, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 04/18] aio: make ctx->list_lock a QemuLockCnt, subsuming ctx->walking_bh, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 06/18] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 09/18] aio: push aio_context_acquire/release down to dispatching, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 10/18] async: optimize aio_bh_poll, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 16/18] quorum: split quorum_fifo_aio_cb from quorum_aio_cb, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 05/18] aio: tweak walking in dispatch phase,
Paolo Bonzini <=
- [Qemu-block] [PATCH 08/18] aio: document locking, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 14/18] block: explicitly acquire aiocontext in timers that need it, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 01/18] iothread: release iothread around aio_poll, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 15/18] quorum: use atomics for rewrite_count, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 07/18] aio-win32: remove walking_handlers, protecting AioHandler list with list_lock, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 18/18] aio: update locking documentation, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 12/18] block: explicitly acquire aiocontext in callbacks that need it, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 17/18] block: explicitly acquire aiocontext in aio callbacks that need it, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 13/18] block: explicitly acquire aiocontext in bottom halves that need it, Paolo Bonzini, 2015/08/06
- [Qemu-block] [PATCH 11/18] qemu-timer: optimize timerlist_run_timers, Paolo Bonzini, 2015/08/06