[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block/raw-posix: Use raw_normalize_devicepath()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH] block/raw-posix: Use raw_normalize_devicepath() |
Date: |
Thu, 13 Aug 2015 15:50:02 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 12.08.2015 um 17:33 hat Max Reitz geschrieben:
> The filename given to qemu_open() in block/raw-posix.c should generally
> have been processed by raw_normalize_devicepath(); unless we are only
> probing (in which case the caller often checks whether the file is a
> block device or not, and this property will be changed by
> raw_normalize_devicepath() on NetBSD) or it is about a deprecated device
> (i.e. floppy).
>
> Signed-off-by: Max Reitz <address@hidden>
The patch isn't actually doing as much as the commit message suggests:
Some calls of qemu_open() where we know that normalising wouldn't change
anything (because we're not on NetBSD or not using a block device) still
don't have the raw_normalize_devicepath() call (e.g. raw_create() and
cdrom_reopen()).
I'm applying the patch anyway because the result is the same.
Kevin