[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCHv2] block/nfs: cache allocated filesize for read-
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCHv2] block/nfs: cache allocated filesize for read-only files |
Date: |
Mon, 24 Aug 2015 20:39:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 24.08.2015 10:06, Peter Lieven wrote:
> If the file is readonly its not expected to grow so
> save the blocking call to nfs_fstat_async and use
> the value saved at connection time. Also important
> the monitor (and thus the main loop) will not hang
> if block device info is queried and the NFS share
> is unresponsive.
>
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> v1->v2: update cache on reopen_prepare [Max]
>
> block/nfs.c | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
Reviewed-by: Max Reitz <address@hidden>
I hope you're ready for the "Stale actual-size value with
cache=direct,read-only=on,format=raw files on NFS" reports. :-)