Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] block: Allow passing BlockdevOptions to blockdev-snapshot-sync

[Alberto Garcia]

On Tue 01 Sep 2015 04:40:02 PM CEST, Kevin Wolf wrote:

>> > Let's avoid such magic and instead add a new, clean blockdev-*
>> > style command. Maybe call it simply blockdev-snapshot; the -sync
>> > part was added because we knew it wouldn't be the final version of
>> > the command.  Now we don't have any bdrv_open() in it any more that
>> > could by synchronous or asynchronous.

Ok, I have a first working prototype of the new command using
references as suggested.

> { 'struct': 'BlockdevSnapshot',
>   'data': { '*device': 'str', '*node-name': 'str',
>             'snapshot-file': 'str', '*snapshot-node-name': 'str',
>             '*format': 'str', '*mode': 'NewImageMode' } }
  [...]
>
> What you really need for the version with a reference is just:
>
> { 'struct': 'BlockdevSnapshot',
>   'data': { 'device': 'str', 'snapshot': 'str' } }

And what do I do with the old BlockdevSnapshot? I guess it can just be
renamed to BlockdevSnapshotSync or something like that?

Berto