[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 1/4] Add new block driver interface to add/de
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v4 1/4] Add new block driver interface to add/delete a BDS's child |
Date: |
Fri, 18 Sep 2015 08:52:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/18/2015 04:13 AM, Wen Congyang wrote:
> In some cases, we want to take a quorum child offline, and take
> another child online.
>
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> block.c | 50
> +++++++++++++++++++++++++++++++++++++++++++++++
> include/block/block.h | 5 +++++
> include/block/block_int.h | 5 +++++
> 3 files changed, 60 insertions(+)
>
> +void bdrv_del_child(BlockDriverState *parent_bs, BlockDriverState *child_bs,
> + Error **errp)
> +{
> + BdrvChild *child;
> + if (!child) {
> + error_setg(errp, "The BDS %s is not the BDS %s's child",
> + bdrv_get_device_or_node_name(child_bs),
> + bdrv_get_device_or_node_name(parent_bs));
Better would be:
"BDS %s is not a child of %s"
With that,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature