[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 0/4] Add 'blockdev-snapshot' command
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v5 0/4] Add 'blockdev-snapshot' command |
Date: |
Fri, 18 Sep 2015 09:12:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/18/2015 07:16 AM, Alberto Garcia wrote:
> This fixes the problem detect by Fam: the previous series was deleting
> the 'backing' option for 'blockdev-add' even if it contained a
> non-empty string.
>
> The code is also rebased on top of the current master. In particular
> the test output had to be adapted because of fe646693.
>
> Again, this depends on Max's BlockBackend and media series:
>
> https://lists.gnu.org/archive/html/qemu-block/2015-07/msg00382.html
>
> Berto
>
> v5:
> - Don't delete the 'backing' option if it contains something different
> from an empty string.
> - Rebase on top of the current master.
Oops, I added some review comments on v4 before seeing that you had
already posted v5. I have some potential naming changes to 3/4 that
should be considered (namely, s/snapshot/overlay/ for the name of the
node that is being added to the chain); and which may necessitate a v6.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature