[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 19/38] block: Fail requests to empty BlockBac
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH v5 19/38] block: Fail requests to empty BlockBackend |
|
Date: |
Tue, 22 Sep 2015 17:05:30 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 22.09.2015 16:30, Kevin Wolf wrote:
> Am 18.09.2015 um 17:22 hat Max Reitz geschrieben:
>> If there is no BlockDriverState in a BlockBackend or if the tray of the
>> guest device is open, fail all requests (where that is possible) with
>> -ENOMEDIUM.
>>
>> The reason the status of the guest device is taken into account is
>> because once the guest device's tray is opened, any request on the same
>> BlockBackend as the guest uses should fail. If the BDS tree is supposed
>> to be usable even after ejecting it from the guest, a different
>> BlockBackend must be used.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>
> Do we want to include blk_drain() to make it a no-op instead of
> crashing?
Yes, we do, so that would be in patch 20. Thanks for catching that.
> Also, we're now introducing BlockAIOCBs with a NULL bs with your use of
> abort_aio_request. I haven't carefully reviewed the implications of this
> yet, but that should definitely be done before we merge the series.
That should be patch 12.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v5 14/38] block: Remove wr_highest_sector from BlockAcctStats, (continued)
[Qemu-block] [PATCH v5 15/38] block: Move BlockAcctStats into BlockBackend, Max Reitz, 2015/09/18
[Qemu-block] [PATCH v5 17/38] block: Add BlockBackendRootState, Max Reitz, 2015/09/18
[Qemu-block] [PATCH v5 16/38] block: Move I/O status and error actions into BB, Max Reitz, 2015/09/18
[Qemu-block] [PATCH v5 18/38] block: Make some BB functions fall back to BBRS, Max Reitz, 2015/09/18
[Qemu-block] [PATCH v5 19/38] block: Fail requests to empty BlockBackend, Max Reitz, 2015/09/18
[Qemu-block] [PATCH v5 20/38] block: Prepare remaining BB functions for NULL BDS, Max Reitz, 2015/09/18
[Qemu-block] [PATCH v5 21/38] block: Add blk_insert_bs(), Max Reitz, 2015/09/18
[Qemu-block] [PATCH v5 22/38] block: Prepare for NULL BDS, Max Reitz, 2015/09/18
[Qemu-block] [PATCH v5 23/38] blockdev: Do not create BDS for empty drive, Max Reitz, 2015/09/18