[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PULL 2/8] hmp: Allow for error message hi
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on HMP |
|
Date: |
Tue, 22 Sep 2015 11:02:43 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/22/2015 09:23 AM, Kevin Wolf wrote:
> Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben:
>> From: Eric Blake <address@hidden>
>>
>> Commits 7216ae3d and d2828429 disabled some error message hints,
>> all because a change to use modern error reporting meant that the
>> hint would be output prior to the actual error. Fix this by making
>> hints a first-class member of Error.
>>
>> For example, we are now back to the pleasant:
>>
>> $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
>> qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an
>> identifier
>> Identifiers consist of letters, digits, '-', '.', '_', starting with a
>> letter.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>> Reviewed-by: Paolo Bonzini <address@hidden>
>> Message-Id: <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> This broke qemu-iotests 049. Can you please send a patch to update the
> reference output?
Will do (and I guess I should run qemu-iotests more frequently. Does
'make check' suffice, or is there other magic involved?)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature