[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 11/16] Add new block driver interfa
From: |
Wen Congyang |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 11/16] Add new block driver interfaces to control block replication |
Date: |
Fri, 25 Sep 2015 14:14:35 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/03/2015 12:33 AM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <address@hidden>
>> Signed-off-by: zhanghailiang <address@hidden>
>> Signed-off-by: Gonglei <address@hidden>
>> Cc: Luiz Capitulino <address@hidden>
>> Cc: Michael Roth <address@hidden>
>> Reviewed-by: Paolo Bonzini <address@hidden>
>> ---
>> block.c | 43 +++++++++++++++++++++++++++++++++++++++++++
>> include/block/block.h | 5 +++++
>> include/block/block_int.h | 14 ++++++++++++++
>> qapi/block-core.json | 15 +++++++++++++++
>> 4 files changed, 77 insertions(+)
>>
>
> Just an interface review for now:
>
>> +++ b/qapi/block-core.json
>> @@ -1810,6 +1810,21 @@
>> 'data': { '*export': 'str' } }
>>
>> ##
>> +# @ReplicationMode
>> +#
>> +# An enumeration of replication modes.
>> +#
>> +# @unprotected: Replication is not started or after failover.
>
> Maybe:
>
> Replication is either not started, or has experienced failover.
This is internal state, and this mode is used to tell qemu that
it is on which side.
Thanks
Wen Congyang
>
>> +#
>> +# @primary: Primary mode, the vm's state will be sent to secondary QEMU.
>> +#
>> +# @secondary: Secondary mode, receive the vm's state from primary QEMU.
>> +#
>> +# Since: 2.4
>
> You've missed 2.4; this should be 2.5.
>
>> +##
>> +{ 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
>
> Where is 'unprotected' in this list?
>
- [Qemu-block] [PATCH 13/16] quorum: implement block driver interfaces for block replication, (continued)
- [Qemu-block] [PATCH 13/16] quorum: implement block driver interfaces for block replication, Wen Congyang, 2015/09/02
- [Qemu-block] [PATCH 15/16] support replication driver in blockdev-add, Wen Congyang, 2015/09/02
- [Qemu-block] [PATCH 10/16] docs: block replication's description, Wen Congyang, 2015/09/02
- [Qemu-block] [PATCH 11/16] Add new block driver interfaces to control block replication, Wen Congyang, 2015/09/02
- [Qemu-block] [PATCH 16/16] Add a new API to start/stop replication, do checkpoint to all BDSes, Wen Congyang, 2015/09/02
- [Qemu-block] [PATCH 14/16] Implement new driver for block replication, Wen Congyang, 2015/09/02