[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v10 02/10] Backup: clear all bitmap when doing block
From: |
Wen Congyang |
Subject: |
[Qemu-block] [PATCH v10 02/10] Backup: clear all bitmap when doing block checkpoint |
Date: |
Fri, 25 Sep 2015 14:17:30 +0800 |
Signed-off-by: Wen Congyang <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
---
block/backup.c | 14 ++++++++++++++
blockjob.c | 11 +++++++++++
include/block/blockjob.h | 12 ++++++++++++
3 files changed, 37 insertions(+)
diff --git a/block/backup.c b/block/backup.c
index c61e4c3..5e5995e 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -214,11 +214,25 @@ static void backup_iostatus_reset(BlockJob *job)
}
}
+static void backup_do_checkpoint(BlockJob *job, Error **errp)
+{
+ BackupBlockJob *backup_job = container_of(job, BackupBlockJob, common);
+
+ if (backup_job->sync_mode != MIRROR_SYNC_MODE_NONE) {
+ error_setg(errp, "The backup job only supports block checkpoint in"
+ " sync=none mode");
+ return;
+ }
+
+ hbitmap_reset_all(backup_job->bitmap);
+}
+
static const BlockJobDriver backup_job_driver = {
.instance_size = sizeof(BackupBlockJob),
.job_type = BLOCK_JOB_TYPE_BACKUP,
.set_speed = backup_set_speed,
.iostatus_reset = backup_iostatus_reset,
+ .do_checkpoint = backup_do_checkpoint,
};
static BlockErrorAction backup_error_action(BackupBlockJob *job,
diff --git a/blockjob.c b/blockjob.c
index ca4be94..ea4c44a 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -405,3 +405,14 @@ void block_job_defer_to_main_loop(BlockJob *job,
qemu_bh_schedule(data->bh);
}
+
+void block_job_do_checkpoint(BlockJob *job, Error **errp)
+{
+ if (!job->driver->do_checkpoint) {
+ error_setg(errp, "The job %s doesn't support block checkpoint",
+ BlockJobType_lookup[job->driver->job_type]);
+ return;
+ }
+
+ job->driver->do_checkpoint(job, errp);
+}
diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index dd9d5e6..0b4f386 100644
--- a/include/block/blockjob.h
+++ b/include/block/blockjob.h
@@ -50,6 +50,9 @@ typedef struct BlockJobDriver {
* manually.
*/
void (*complete)(BlockJob *job, Error **errp);
+
+ /** Optional callback for job types that support checkpoint. */
+ void (*do_checkpoint)(BlockJob *job, Error **errp);
} BlockJobDriver;
/**
@@ -356,4 +359,13 @@ void block_job_defer_to_main_loop(BlockJob *job,
BlockJobDeferToMainLoopFn *fn,
void *opaque);
+/**
+ * block_job_do_checkpoint:
+ * @job: The job.
+ * @errp: Error object.
+ *
+ * Do block checkpoint on the specified job.
+ */
+void block_job_do_checkpoint(BlockJob *job, Error **errp);
+
#endif
--
2.4.3
- [Qemu-block] [PATCH v10 00/10] Block replication for continuous checkpoints, Wen Congyang, 2015/09/25
- [Qemu-block] [PATCH v10 02/10] Backup: clear all bitmap when doing block checkpoint,
Wen Congyang <=
- [Qemu-block] [PATCH v10 01/10] allow writing to the backing file, Wen Congyang, 2015/09/25
- [Qemu-block] [PATCH v10 03/10] Allow creating backup jobs when opening BDS, Wen Congyang, 2015/09/25
- [Qemu-block] [PATCH v10 04/10] block: make bdrv_put_ref_bh_schedule() as a public API, Wen Congyang, 2015/09/25
- [Qemu-block] [PATCH v10 06/10] Add new block driver interfaces to control block replication, Wen Congyang, 2015/09/25
- [Qemu-block] [PATCH v10 07/10] quorum: implement block driver interfaces for block replication, Wen Congyang, 2015/09/25
- [Qemu-block] [PATCH v10 09/10] support replication driver in blockdev-add, Wen Congyang, 2015/09/25
- [Qemu-block] [PATCH v10 05/10] docs: block replication's description, Wen Congyang, 2015/09/25
- [Qemu-block] [PATCH v10 10/10] Add a new API to start/stop replication, do checkpoint to all BDSes, Wen Congyang, 2015/09/25
- [Qemu-block] [PATCH v10 08/10] Implement new driver for block replication, Wen Congyang, 2015/09/25