[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 12/16] block: Introduce parents list
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH 12/16] block: Introduce parents list |
|
Date: |
Mon, 28 Sep 2015 15:09:51 +0200 |
|
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Thu 17 Sep 2015 03:48:16 PM CEST, Kevin Wolf wrote:
> @@ -1090,6 +1090,7 @@ static BdrvChild *bdrv_attach_child(BlockDriverState
> *parent_bs,
> };
>
> QLIST_INSERT_HEAD(&parent_bs->children, child, next);
> + QLIST_INSERT_HEAD(&child_bs->parents, child, next_parent);
>
> return child;
> }
Ok, I'm probably slow today, but what is this used for? :-? And why is
it called 'parents'? The list doesn't contain pointers to the parents of
child_bs, but to child_bs itself...
I would expect a BdrvChild *parent, with parent->bs = parent_bs.
Berto
[Qemu-block] [PATCH 14/16] blockjob: Store device name at job creation, Kevin Wolf, 2015/09/17
[Qemu-block] [PATCH 12/16] block: Introduce parents list, Kevin Wolf, 2015/09/17
[Qemu-block] [PATCH 15/16] block: Add and use bdrv_replace_in_backing_chain(), Kevin Wolf, 2015/09/17
[Qemu-block] [PATCH 16/16] block: Remove bdrv_swap(), Kevin Wolf, 2015/09/17
Re: [Qemu-block] [PATCH 00/16] block: Get rid of bdrv_swap(), Alberto Garcia, 2015/09/18
Re: [Qemu-block] [PATCH 00/16] block: Get rid of bdrv_swap(), Alberto Garcia, 2015/09/24