[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/3] block: mirror - zero unallocated target sec
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH 3/3] block: mirror - zero unallocated target sectors when zero init not present |
Date: |
Mon, 28 Sep 2015 16:23:16 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sun, Sep 27, 2015 at 11:29:18PM -0400, Jeff Cody wrote:
> + if (s->zero_cycle) {
> + ret = bdrv_get_block_status(s->target, sector_num, nb_sectors,
> &pnum);
> + if (!(ret & BDRV_BLOCK_ZERO)) {
> + bdrv_aio_write_zeroes(s->target, sector_num, op->nb_sectors,
> + s->unmap ? BDRV_REQ_MAY_UNMAP : 0,
> + mirror_write_complete, op);
mirror_write_complete will advance s->common.offset. Won't the progress
be incorrect if we do that for both zeroing and regular mirroring?
- Re: [Qemu-block] [PATCH 2/3] block: mirror - split out part of mirror_run(), (continued)