[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/3] block: prohibit migration during transactio
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH 3/3] block: prohibit migration during transactions |
|
Date: |
Thu, 1 Oct 2015 20:01:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 01/10/2015 18:34, John Snow wrote:
> +
> + error_setg(&blocker, "Block device(s) are in use by a Block
> Transaction");
s/Block Transaction/transaction command/
But how can migration start during a transaction?
> + ret = migrate_add_blocker(blocker, errp);
> + if (ret < 0) {
> + goto cleanup_mig;
> + }
>
> QSIMPLEQ_HEAD(snap_bdrv_states, BlkTransactionState) snap_bdrv_states;
> QSIMPLEQ_INIT(&snap_bdrv_states);
> @@ -1814,6 +1823,9 @@ exit:
> }
> g_free(state);
> }
> + cleanup_mig:
> + migrate_del_blocker(blocker);
> + error_free(blocker);