[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 08/16] block: Manage backing file references
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 08/16] block: Manage backing file references in bdrv_set_backing_hd() |
Date: |
Fri, 2 Oct 2015 19:18:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 01.10.2015 15:13, Kevin Wolf wrote:
> This simplifies the code somewhat, especially when dropping whole
> backing file subchains.
>
> The exception is the mirroring code that does adventurous things with
> bdrv_swap() and in order to keep it working, I had to duplicate most of
> bdrv_set_backing_hd() locally. We'll get rid again of this ugliness
> shortly.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 35 ++++++++++++++---------------------
> block/mirror.c | 16 ++++++++++++----
> block/stream.c | 30 +-----------------------------
> block/vvfat.c | 6 +++++-
> include/block/block.h | 1 +
> 5 files changed, 33 insertions(+), 55 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 03/16] blkverify: Convert s->test_file to BdrvChild, (continued)
- [Qemu-block] [PATCH v2 03/16] blkverify: Convert s->test_file to BdrvChild, Kevin Wolf, 2015/10/08
- [Qemu-block] [PATCH v2 09/16] block: Split bdrv_move_feature_fields(), Kevin Wolf, 2015/10/08
- [Qemu-block] [PATCH v2 07/16] block: Convert bs->backing_hd to BdrvChild, Kevin Wolf, 2015/10/08
- [Qemu-block] [PATCH v2 08/16] block: Manage backing file references in bdrv_set_backing_hd(), Kevin Wolf, 2015/10/08
- [Qemu-block] [PATCH v2 10/16] block/io: Make bdrv_requests_pending() public, Kevin Wolf, 2015/10/08
- [Qemu-block] [PATCH v2 12/16] block: Introduce parents list, Kevin Wolf, 2015/10/08
- [Qemu-block] [PATCH v2 13/16] block: Implement bdrv_append() without bdrv_swap(), Kevin Wolf, 2015/10/08
- [Qemu-block] [PATCH v2 02/16] vmdk: Use BdrvChild instead of BDS for references to extents, Kevin Wolf, 2015/10/08
- [Qemu-block] [PATCH v2 01/16] block: Introduce BDS.file_child, Kevin Wolf, 2015/10/08
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/16] block: Get rid of bdrv_swap(), Fam Zheng, 2015/10/08
- Re: [Qemu-block] [PATCH v2 00/16] block: Get rid of bdrv_swap(), Stefan Hajnoczi, 2015/10/09