[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH] Revert "blockdev: add note that block_job_cb() must
From: |
Fam Zheng |
Subject: |
[Qemu-block] [PATCH] Revert "blockdev: add note that block_job_cb() must be thread-safe" |
Date: |
Tue, 13 Oct 2015 18:16:15 +0800 |
This reverts commit 723c5d93c51bdb3adbc238ce90195c0864aa6cd5.
block_job_cb is called by block_job_completed, which is always called in
a main loop bottom half in existing block jobs. So we don't need to
worry about thread-safety here.
Signed-off-by: Fam Zheng <address@hidden>
---
blockdev.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 32b04b4..130b7fb 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2248,11 +2248,6 @@ out:
static void block_job_cb(void *opaque, int ret)
{
- /* Note that this function may be executed from another AioContext besides
- * the QEMU main loop. If you need to access anything that assumes the
- * QEMU global mutex, use a BH or introduce a mutex.
- */
-
BlockDriverState *bs = opaque;
const char *msg = NULL;
--
2.6.1
- [Qemu-block] [PATCH] Revert "blockdev: add note that block_job_cb() must be thread-safe",
Fam Zheng <=