[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v7 28/39] blockdev: Add blockdev-open-tray
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v7 28/39] blockdev: Add blockdev-open-tray |
Date: |
Fri, 23 Oct 2015 15:26:44 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 19.10.2015 um 17:53 hat Max Reitz geschrieben:
> Signed-off-by: Max Reitz <address@hidden>
> ---
> blockdev.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> qapi/block-core.json | 23 +++++++++++++++++++++++
> qmp-commands.hx | 39 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 111 insertions(+)
> + bs = blk_bs(blk);
> + if (bs) {
> + aio_context = bdrv_get_aio_context(bs);
> + aio_context_acquire(aio_context);
> +
> + if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_EJECT, errp)) {
> + goto out;
> + }
Is this blocker really for protecting against opening the tray? I think
the BDS shouldn't care about whether the guest can access it. So it's
probably more about preventing a bdrv_close() from happening, i.e. it
would be relevant only for the blockdev-remove-medium command.
Kevin
- [Qemu-block] [PATCH v7 23/39] block: Prepare for NULL BDS, (continued)
- [Qemu-block] [PATCH v7 23/39] block: Prepare for NULL BDS, Max Reitz, 2015/10/19
- [Qemu-block] [PATCH v7 24/39] blockdev: Do not create BDS for empty drive, Max Reitz, 2015/10/19
- [Qemu-block] [PATCH v7 25/39] blockdev: Pull out blockdev option extraction, Max Reitz, 2015/10/19
- [Qemu-block] [PATCH v7 26/39] blockdev: Allow more options for BB-less BDS tree, Max Reitz, 2015/10/19
- [Qemu-block] [PATCH v7 27/39] block: Add blk_remove_bs(), Max Reitz, 2015/10/19
- [Qemu-block] [PATCH v7 28/39] blockdev: Add blockdev-open-tray, Max Reitz, 2015/10/19
[Qemu-block] [PATCH v7 30/39] blockdev: Add blockdev-remove-medium, Max Reitz, 2015/10/19
[Qemu-block] [PATCH v7 29/39] blockdev: Add blockdev-close-tray, Max Reitz, 2015/10/19
[Qemu-block] [PATCH v7 31/39] blockdev: Add blockdev-insert-medium, Max Reitz, 2015/10/19