|
From: | Alberto Garcia |
Subject: | Re: [Qemu-block] [PATCH v8 01/15] block: Add blk_remove_bs() |
Date: | Tue, 27 Oct 2015 10:04:55 +0100 |
User-agent: | Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Mon 26 Oct 2015 09:39:05 PM CET, Max Reitz <address@hidden> wrote: > +void blk_remove_bs(BlockBackend *blk) > +{ > + blk_update_root_state(blk); > + > + blk->bs->blk = NULL; > + bdrv_unref(blk->bs); > + blk->bs = NULL; > +} I cannot think of any example out of the blue but I wonder if removing the reference to the BDS (and possibly destroying it) while blk->bs is still pointing to it could be a source of problems. Berto
[Prev in Thread] | Current Thread | [Next in Thread] |