Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/2] block: test 'blockdev-snapshot' using a file BDS as the overlay

[Eric Blake]

On 11/02/2015 10:07 AM, Max Reitz wrote:
> On 02.11.2015 13:15, Alberto Garcia wrote:
>> This test checks that it is not possible to create a snapshot using as
>> the overlay node a BDS that does not support backing images.
> 
> I don't think that works in English. I may be wrong, of course.
> 
> "a snapshot using a BDS that does not support backing images as the
> overlay node", "a snapshot with the overlay node being a BDS that...",
> "a snapshot using a BDS as the overlay node that...", or something like
> that might work.
> 

How about:

This test checks that it is not possible to create a snapshot if the
requested overlay node is a BDS which does not support backing images.

>> +++ b/tests/qemu-iotests/085
>> @@ -103,7 +103,8 @@ function add_snapshot_image()
>>             { 'options':
>>               { 'driver': 'qcow2', 'node-name': 'snap_"${1}"', 
>> "${extra_params}"
>>                 'file':
>> -               { 'driver': 'file', 'filename': '"${snapshot_file}"' } } } }"
>> +               { 'driver': 'file', 'filename': '"${snapshot_file}"',
>> +                 'node-name': 'file_"${1}"' } } } }"
> 
> Pre-existing, but do those "" actually do anything?
> 

Actually, the "" are wrong.  Look at the full context: we have:

cmd="..."${snapshot_file}"..."

which means the expansion of $snapshot_file is _unquoted_.  We really
want either:

cmd='...'"${snapshot_file}"'...'

(if we wanted to write the command with " instead of ' for internal
string quoting), or:

cmd="...${snapshot_file}..."


I suspect that it crept in because locally we have ' in the ..., and
'${...}' in isolation is usually wrong (which is why you have to look at
the full string, and not just the local change).

> Since the latter is mainly out of curiosity, and because English too not
> my mother language is, which is why I not the one be should, who himself
> over that complains*:

LOL

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature