qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v10 08/14] blockjob: Simplify block_job_finish_s


From: Stefan Hajnoczi
Subject: Re: [Qemu-block] [PATCH v10 08/14] blockjob: Simplify block_job_finish_sync
Date: Tue, 3 Nov 2015 13:52:28 +0000
User-agent: Mutt/1.5.24 (2015-08-30)

On Fri, Oct 23, 2015 at 07:56:46PM -0400, John Snow wrote:
> +    block_job_ref(job);
>      finish(job, &local_err);
>      if (local_err) {
>          error_propagate(errp, local_err);
>          return -EBUSY;

Refcount leak, missing block_job_unref(job).

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]