Re: [Qemu-block] [PATCH v7 11/35] util: introduce qemu_file_getlength()

[Xiao Guangrong]

On 11/06/2015 11:50 PM, Eduardo Habkost wrote:
> As this patch affects raw_getlength(), CCing the raw block driver
> maintainer and the qemu-block mailing list.

Eduardo, thanks for your reminder. I will keep CCing Kevin and qemu-block mail
list for future version.

> On Mon, Nov 02, 2015 at 05:13:13PM +0800, Xiao Guangrong wrote:
> > It is used to get the size of the specified file, also qemu_fd_getlength()
> > is introduced to unify the code with raw_getlength() in block/raw-posix.c
> >
> > Signed-off-by: Xiao Guangrong <address@hidden>
> > ---
> >   block/raw-posix.c    |  7 +------
> >   include/qemu/osdep.h |  2 ++
> >   util/osdep.c         | 31 +++++++++++++++++++++++++++++++
>
> I know I was the one who suggested osdep.c, but maybe oslib-posix.c is a
> more appropriate place for the new function?

Since the function we introduced here can work on both windows and posix, so
i thing osdep.c is the right place. Otherwise we should implement it for 
multiple
platforms.