[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v7 04/24] iotests: Rename filter_nbd to _filter_nbd
From: |
Max Reitz |
Subject: |
[Qemu-block] [PATCH v7 04/24] iotests: Rename filter_nbd to _filter_nbd in 083 |
Date: |
Mon, 9 Nov 2015 23:39:13 +0100 |
In the patch after the next, this function is moved to common.filter.
Therefore, its name should be preceded by an underscore to signify its
global availability.
To keep the code motion patch clean, we cannot rename it in the same
patch, so we need to choose some order of renaming vs. motion. It is
better to keep a supposedly global function used by only a single test
in that test than to keep a supposedly local function in a common* file
and use it from a test, so we should rename the function before moving
it.
Signed-off-by: Max Reitz <address@hidden>
---
tests/qemu-iotests/083 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/083 b/tests/qemu-iotests/083
index 1b2d3f1..664f0cf 100755
--- a/tests/qemu-iotests/083
+++ b/tests/qemu-iotests/083
@@ -49,7 +49,7 @@ wait_for_tcp_port() {
done
}
-filter_nbd() {
+_filter_nbd() {
# nbd.c error messages contain function names and line numbers that are
prone
# to change. Message ordering depends on timing between send and
receive
# callbacks sometimes, making them unreliable.
@@ -84,7 +84,7 @@ EOF
$PYTHON nbd-fault-injector.py $extra_args "127.0.0.1:$port"
"$TEST_DIR/nbd-fault-injector.conf" 2>&1 >/dev/null &
wait_for_tcp_port "127\\.0\\.0\\.1:$port"
- $QEMU_IO -c "read 0 512" "$nbd_url" 2>&1 | _filter_qemu_io | filter_nbd
+ $QEMU_IO -c "read 0 512" "$nbd_url" 2>&1 | _filter_qemu_io | _filter_nbd
echo
}
--
2.6.2
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), (continued)
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/12
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/16
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/16
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/16
- [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/17
- Re: [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), Fam Zheng, 2015/11/17
- Re: [Qemu-block] [Qemu-devel] Closing Bitmaps (Was: Re: [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/18
- Re: [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), Kevin Wolf, 2015/11/18
- Re: [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/18
[Qemu-block] [PATCH v7 04/24] iotests: Rename filter_nbd to _filter_nbd in 083,
Max Reitz <=
[Qemu-block] [PATCH v7 05/24] iotests: Change coding style of _filter_nbd in 083, Max Reitz, 2015/11/09
[Qemu-block] [PATCH v7 06/24] iotests: Move _filter_nbd into common.filter, Max Reitz, 2015/11/09
[Qemu-block] [PATCH v7 07/24] iotests: Make _filter_nbd drop log lines, Max Reitz, 2015/11/09
[Qemu-block] [PATCH v7 08/24] iotests: Make _filter_nbd support more URL types, Max Reitz, 2015/11/09
[Qemu-block] [PATCH v7 09/24] iotests: Make redirecting qemu's stderr optional, Max Reitz, 2015/11/09