[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/4] hw/ide: Remove superfluous return statement
From: |
John Snow |
Subject: |
Re: [Qemu-block] [PATCH 1/4] hw/ide: Remove superfluous return statements |
Date: |
Tue, 10 Nov 2015 15:17:55 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/10/2015 03:16 PM, Thomas Huth wrote:
> The "return;" statements at the end of functions do not make
> much sense, so let's remove them.
>
> Cc: John Snow <address@hidden>
> Cc: address@hidden
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> hw/ide/atapi.c | 1 -
> hw/ide/macio.c | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index 747f466..347c6e7 100644
> --- a/hw/ide/atapi.c
> +++ b/hw/ide/atapi.c
> @@ -737,7 +737,6 @@ static void cmd_inquiry(IDEState *s, uint8_t *buf)
> out:
> buf[size_idx] = idx - preamble_len;
> ide_atapi_cmd_reply(s, idx, max_len);
> - return;
> }
>
> static void cmd_get_configuration(IDEState *s, uint8_t *buf)
> diff --git a/hw/ide/macio.c b/hw/ide/macio.c
> index 893c9b9..8a56115 100644
> --- a/hw/ide/macio.c
> +++ b/hw/ide/macio.c
> @@ -288,8 +288,6 @@ static void pmac_ide_atapi_transfer_cb(void *opaque, int
> ret)
> done:
> block_acct_done(blk_get_stats(s->blk), &s->acct);
> io->dma_end(opaque);
> -
> - return;
> }
>
> static void pmac_ide_transfer_cb(void *opaque, int ret)
>
Fair enough.
Reviewed-by: John Snow <address@hidden>