[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v11 18/28] qerror: more error_setg() usage
From: |
Andreas Färber |
Subject: |
Re: [Qemu-block] [PATCH v11 18/28] qerror: more error_setg() usage |
Date: |
Wed, 11 Nov 2015 14:26:05 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
Am 11.11.2015 um 07:51 schrieb Eric Blake:
> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in
> since c6bd8c706. Nuke them.
>
> Signed-off-by: Eric Blake <address@hidden>
[...]
> diff --git a/qom/object.c b/qom/object.c
> index fc6e161..c0decb6 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -1330,8 +1330,8 @@ static Object *object_resolve_link(Object *obj, const
> char *name,
> target = object_resolve_path_type(path, target_type, &ambiguous);
>
> if (ambiguous) {
> - error_set(errp, ERROR_CLASS_GENERIC_ERROR,
> - "Path '%s' does not uniquely identify an object", path);
> + error_setg(errp, "Path '%s' does not uniquely identify an object",
> + path);
> } else if (!target) {
> target = object_resolve_path(path, &ambiguous);
> if (target || ambiguous) {
Acked-by: Andreas Färber <address@hidden>
No idea why it's this way, maybe predated the function?
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)