Re: [Qemu-block] [PATCH v12 22/36] qapi: Don't let implicit enum MAX member collide

[Juan Quintela]

Eric Blake <address@hidden> wrote:
> Now that we guarantee the user doesn't have any enum values
> beginning with a single underscore, we can use that for our
> own purposes.  Renaming ENUM_MAX to ENUM__MAX makes it obvious
> that the sentinel is generated.
>
> This patch was mostly generated by applying a temporary patch:
>
> |diff --git a/scripts/qapi.py b/scripts/qapi.py
> |index e6d014b..b862ec9 100644
> |--- a/scripts/qapi.py
> |+++ b/scripts/qapi.py
> |@@ -1570,6 +1570,7 @@ const char *const %(c_name)s_lookup[] = {
> |     max_index = c_enum_const(name, 'MAX', prefix)
> |     ret += mcgen('''
> |     [%(max_index)s] = NULL,
> |+// %(max_index)s
> | };
> | ''',
> |                max_index=max_index)
>
> then running:
>
> $ cat qapi-{types,event}.c tests/test-qapi-types.c |
>     sed -n 's,^// \(.*\)MAX,s|\1MAX|\1_MAX|g,p' > list
> $ git grep -l _MAX | xargs sed -i -f list
>
> The only things not generated are the changes in scripts/qapi.py.
>
> Signed-off-by: Eric Blake <address@hidden>

For migration bits, I have zero objections about the changes.  I trust
you that you have done all the required changes (i.e. I haven't compiled
it).  Rest of the patch is as trivial as the commit log explains, so


Reviewed-by: Juan Quintela <address@hidden>

Thanks, Juan.