[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v7 02/24] blockjob: Call bdrv_unref() on creatio
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v7 02/24] blockjob: Call bdrv_unref() on creation error |
Date: |
Wed, 18 Nov 2015 16:24:29 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 09.11.2015 um 23:39 hat Max Reitz geschrieben:
> If block_job_create() fails, it should release its reference to the
> job's BDS. Normally, this is done in the callback provided by the
> caller, but that callback will not be invoked if the block job failed to
> be created.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
Commit 18930ba3 already fixed this. Now adding another bdrv_unref()
would be wrong, so I guess we have to simply drop the patch.
NACK
- [Qemu-block] [PATCH v7 for-2.6 00/24] block: Rework bdrv_close_all(), Max Reitz, 2015/11/09
- [Qemu-block] [PATCH v7 01/24] blockdev: Add missing bdrv_unref() in drive-backup, Max Reitz, 2015/11/09
- [Qemu-block] [PATCH v7 02/24] blockjob: Call bdrv_unref() on creation error, Max Reitz, 2015/11/09
- [Qemu-block] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Max Reitz, 2015/11/09
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/11
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/12
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/16
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/16
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/16
- [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/17
- Re: [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), Fam Zheng, 2015/11/17
- Re: [Qemu-block] [Qemu-devel] Closing Bitmaps (Was: Re: [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/18