[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] tests: fix cdrom_pio_impl in ide-t
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] tests: fix cdrom_pio_impl in ide-test |
|
Date: |
Fri, 20 Nov 2015 17:38:19 +0000 |
On 20 November 2015 at 17:12, John Snow <address@hidden> wrote:
> This looks correct. This will definitely fix the race in the test, since
> it was due to a race where we were reading the data when DRQ was not set.
>
> Where I still remain a little confused is the precise flow control that
> leads to sending an interrupt where BSY is set and DRQ is clear.
>
> I'd like to investigate that a little more, but for purposes of rc1 and
> testing I think this is the right thing to do.
>
> For rc1, however:
> Reviewed-by: John Snow <address@hidden>
Thanks, applied to master (I fixed the commit message typo).
-- PMM