qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 03/21] mirror: Error out when a BDS would get


From: Alberto Garcia
Subject: Re: [Qemu-block] [PATCH v2 03/21] mirror: Error out when a BDS would get two BBs
Date: Mon, 30 Nov 2015 15:51:18 +0100
User-agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)

On Mon 23 Nov 2015 04:59:42 PM CET, Kevin Wolf wrote:

> @@ -370,11 +371,22 @@ static void mirror_exit(BlockJob *job, void *opaque)
>          if (s->to_replace) {
>              to_replace = s->to_replace;
>          }
> +
> +        /* This was checked in mirror_start_job(), but meanwhile one of the
> +         * nodes could have been newly attached to a BlockBackend. */
> +        if (to_replace->blk && s->target->blk) {
> +            error_report("block job: Can't create node with two 
> BlockBackends");
> +            data->ret = -EINVAL;
> +            goto out;
> +        }

Does it make sense to even allow attaching a BDS to a Block Backend
during this block job? Is there any use case for that?

Berto



reply via email to

[Prev in Thread] Current Thread [Next in Thread]