[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/3] block: Don't wait serialising for non-COR r
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH 1/3] block: Don't wait serialising for non-COR read requests |
|
Date: |
Tue, 1 Dec 2015 10:54:36 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 01.12.2015 um 10:36 hat Fam Zheng geschrieben:
> The assertion problem was noticed in 06c3916b35a, but it wasn't
> completely fixed, because even though the req is not marked as
> serialising, it still gets serialised by wait_serialising_requests
> against other serialising requests, which could lead to the same
> assertion failure.
>
> Fix it by even more explicitly skipping the serialising for this
> specific case.
>
> Signed-off-by: Fam Zheng <address@hidden>
And this, my friends, is another example why read/write notifiers are
wrong and should die sooner rather than later. </broken-record>
Kevin