[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] fix:readcapacity 10 failure shown even 16 sent
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH] fix:readcapacity 10 failure shown even 16 sent |
|
Date: |
Thu, 10 Dec 2015 09:55:40 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/12/2015 03:59, Zhu Lingshan wrote:
> - if (task == NULL || task->status != SCSI_STATUS_GOOD) {
> + if ((rc16 != NULL) && ((task == NULL) || (task->status !=
> SCSI_STATUS_GOOD))) {
> + error_setg(errp, "iSCSI: failed to send readcapacity16 command.");
> + }
You need an "else" here.
Paolo
> + if ((rc10 != NULL) && ((task == NULL) || (task->status !=
> SCSI_STATUS_GOOD))) {
> error_setg(errp, "iSCSI: failed to send readcapacity10 command.");
> } else if (!iscsilun->block_size ||