[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] block/qapi: Clear err for further
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] block/qapi: Clear err for further error |
Date: |
Tue, 22 Dec 2015 09:39:15 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/22/2015 05:11 AM, Fam Zheng wrote:
> Since a5002d5 (block/qapi: allow best-effort query) we don't return at
> this error, however err must be cleared before passing to
> bdrv_query_snapshot_info_list below, as required by error API.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/qapi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/qapi.c b/block/qapi.c
> index fecac25..58d3975 100644
> --- a/block/qapi.c
> +++ b/block/qapi.c
> @@ -250,6 +250,7 @@ void bdrv_query_image_info(BlockDriverState *bs,
> g_free(backing_filename2);
> backing_filename2 = NULL;
> error_free(err);
> + err = NULL;
> }
>
> /* Always report the full_backing_filename if present, even if it's
> the
>
Sorry Markus, I've failed you.
Reviewed-by: John Snow <address@hidden>