qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 01/10] qcow2: Write feature table only for v3 im


From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 01/10] qcow2: Write feature table only for v3 images
Date: Tue, 22 Dec 2015 13:20:27 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 12/22/2015 09:46 AM, Kevin Wolf wrote:
> Version 2 images don't have feature bits, so writing a feature table to
> those images is kind of pointless.

Fortunately, it is also harmless; even the v2 spec allowed for unknown
extension headers.

> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qcow2.c              | 48 
> ++++++++++++++++++++++++----------------------
>  tests/qemu-iotests/031.out | 12 +-----------
>  tests/qemu-iotests/061.out | 15 ---------------
>  3 files changed, 26 insertions(+), 49 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

Did you test that amend'ing an image from v2 to v3 adds the table, and
downgrading from v3 to v2 drops the table?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]