[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v7 1/2] mirror: Rewrite mirror_iteration
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH v7 1/2] mirror: Rewrite mirror_iteration |
Date: |
Thu, 24 Dec 2015 10:54:34 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, 12/24 01:21, Max Reitz wrote:
> On 24.12.2015 01:15, Max Reitz wrote:
> > On 23.12.2015 05:12, Fam Zheng wrote:
> >> The "pnum < nb_sectors" condition in deciding whether to actually copy
> >> data is unnecessarily strict, and the qiov initialization is
> >> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard.
> >>
> >> Rewrite mirror_iteration to fix both flaws.
> >>
> >> Signed-off-by: Fam Zheng <address@hidden>
> >> ---
> >> block/mirror.c | 308
> >> +++++++++++++++++++++++++++++++++++----------------------
> >> 1 file changed, 188 insertions(+), 120 deletions(-)
> >
> > Reviewed-by: Max Reitz <address@hidden>
>
> Forgot to note: I think this patch needs a rebase already.
>
Thanks for noticing that! I'm rebasing it now.
Fam