[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 0/2] block: Reject negative values for throttling
From: |
Fam Zheng |
Subject: |
[Qemu-block] [PATCH v2 0/2] block: Reject negative values for throttling options |
Date: |
Wed, 13 Jan 2016 08:52:28 +0800 |
v2: Check the value range and report an appropriate error. [Berto]
Now the negative values are silently converted to a huge positive number
because we are doing implicit casting from uint64_t to double. Fix it and add a
test case (this was once fixed in 7d81c1413c9 but regressed when the block
device option parsing code was changed).
Fam Zheng (2):
blockdev: Error out on negative throttling option values
iotests: Test that negative throttle values are rejected
blockdev.c | 3 ++-
include/qemu/throttle.h | 2 ++
tests/qemu-iotests/051 | 11 +++++++++++
tests/qemu-iotests/051.out | 21 +++++++++++++++++++++
tests/qemu-iotests/051.pc.out | 21 +++++++++++++++++++++
util/throttle.c | 16 ++++++----------
6 files changed, 63 insertions(+), 11 deletions(-)
--
2.4.3
- [Qemu-block] [PATCH v2 0/2] block: Reject negative values for throttling options,
Fam Zheng <=
[Qemu-block] [PATCH v2 2/2] iotests: Test that negative throttle values are rejected, Fam Zheng, 2016/01/12