[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 1/3] nbd: Always call "close_fn" in nbd_clien
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-block] [PATCH v3 1/3] nbd: Always call "close_fn" in nbd_client_new |
Date: |
Thu, 14 Jan 2016 17:23:59 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Jan 14, 2016 at 04:41:01PM +0800, Fam Zheng wrote:
> Rename the parameter "close" to "close_fn" to disambiguous with
> close(2).
>
> This unifies error handling paths of NBDClient allocation:
> nbd_client_new will shutdown the socket and call the "close_fn" callback
> if negotiation failed, so the caller don't need a different path than
> the normal close.
>
> The returned pointer is never used, make it void in preparation for the
> next patch.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> blockdev-nbd.c | 5 ++---
> include/block/nbd.h | 3 +--
> nbd.c | 11 +++++------
> qemu-nbd.c | 10 +++-------
> 4 files changed, 11 insertions(+), 18 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|