[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v4 04/12] fdc: add disk field
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v4 04/12] fdc: add disk field |
|
Date: |
Wed, 20 Jan 2016 15:59:30 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 01/20/2016 03:35 PM, Eric Blake wrote:
> On 01/19/2016 11:51 PM, John Snow wrote:
>> Currently, 'drive' is used both to represent the current diskette
>> type as well as the current drive type.
>>
>> This patch adds a 'disk' field that is updated explicitly to match
>> the type of the disk.
>>
>> As of this patch, disk and drive are always the same, but forthcoming
>> patches to change the behavior of pick_geometry will invalidate this
>> assumption.
>>
>> disk does not need to be migrated because it is not user-visible state
>> nor is it currently used for any calculations. It is purely informative,
>> and will be rebuilt automatically via fd_revalidate on the new host.
>>
>> Signed-off-by: John Snow <address@hidden>
>> ---
>> hw/block/fdc.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>
> Reviewed-by: Eric Blake <address@hidden>
>
Grazie.
--js
- [Qemu-block] [PATCH v4 02/12] fdc: reduce number of pick_geometry arguments, (continued)
- [Qemu-block] [PATCH v4 02/12] fdc: reduce number of pick_geometry arguments, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 05/12] fdc: Throw an assertion on misconfigured fd_formats table, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 03/12] fdc: add drive type qapi enum, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 04/12] fdc: add disk field, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 07/12] fdc: Add fallback option, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 09/12] fdc: add physical disk sizes, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 06/12] fdc: add pick_drive, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 08/12] fdc: add drive type option, John Snow, 2016/01/20