qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 00/13] Dirty bitmap changes for migration/per


From: Fam Zheng
Subject: Re: [Qemu-block] [PATCH v2 00/13] Dirty bitmap changes for migration/persistence work
Date: Thu, 21 Jan 2016 21:03:59 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, 01/21 13:41, Vladimir Sementsov-Ogievskiy wrote:
> An idea/question.
> 
> What about make some const dirty bitmap finctions really const?
> 
> bdrv_dirty_bitmap_name(BdrvDirtyBitmap *bitmap)   ->
> bdrv_dirty_bitmap_name(const BdrvDirtyBitmap *bitmap)
> bdrv_dirty_bitmap_size(BdrvDirtyBitmap *bitmap)     ->
> bdrv_dirty_bitmap_size(const BdrvDirtyBitmap *bitmap)
> 
> etc..

That is fine. I think that is a good practice which is not always adopted.

Fam



reply via email to

[Prev in Thread] Current Thread [Next in Thread]