|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-block] [PULL 12/17] qcow2: Implement .bdrv_inactivate |
Date: | Fri, 22 Jan 2016 12:24:04 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 20/01/2016 17:25, Kevin Wolf wrote: > + ret = qcow2_cache_flush(bs, s->refcount_block_cache); > + if (ret) { > + result = ret; > + error_report("Failed to flush the refcount block cache: %s", > + strerror(-ret)); > + } > + > + if (result == 0) { > + qcow2_mark_clean(bs); Should you return an error if qcow2_mark_clean does? (Coverity noticed that its return value is usually checked). Paolo > + } > + > + return result;
[Prev in Thread] | Current Thread | [Next in Thread] |