[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v7 01/15] block: Add "file" output parameter to
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH v7 01/15] block: Add "file" output parameter to block status query functions |
|
Date: |
Fri, 22 Jan 2016 23:56:31 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 22.01.2016 04:06, Fam Zheng wrote:
> The added parameter can be used to return the BDS pointer which the
> valid offset is referring to. Its value should be ignored unless
> BDRV_BLOCK_OFFSET_VALID in ret is set.
>
> Until block drivers fill in the right value, let's clear it explicitly
> right before calling .bdrv_get_block_status.
>
> The "bs->file" condition in bdrv_co_get_block_status is kept now to keep
> iotest
> case 102 passing, and will be fixed once all drivers return the right file
> pointer.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/io.c | 38 ++++++++++++++++++++++++++------------
> block/iscsi.c | 6 ++++--
> block/mirror.c | 3 ++-
> block/parallels.c | 2 +-
> block/qcow.c | 2 +-
> block/qcow2.c | 2 +-
> block/qed.c | 3 ++-
> block/raw-posix.c | 3 ++-
> block/raw_bsd.c | 3 ++-
> block/sheepdog.c | 2 +-
> block/vdi.c | 2 +-
> block/vmdk.c | 2 +-
> block/vpc.c | 2 +-
> block/vvfat.c | 2 +-
> include/block/block.h | 11 +++++++----
> include/block/block_int.h | 3 ++-
> qemu-img.c | 13 +++++++++----
> 17 files changed, 64 insertions(+), 35 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v7 00/15] qemu-img map: Allow driver to return file of the allocated block, Fam Zheng, 2016/01/21
- [Qemu-block] [PATCH v7 01/15] block: Add "file" output parameter to block status query functions, Fam Zheng, 2016/01/21
- Re: [Qemu-block] [PATCH v7 01/15] block: Add "file" output parameter to block status query functions,
Max Reitz <=
- [Qemu-block] [PATCH v7 02/15] qcow: Assign bs->file->bs to file in qcow_co_get_block_status, Fam Zheng, 2016/01/21
- [Qemu-block] [PATCH v7 03/15] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status, Fam Zheng, 2016/01/21
- [Qemu-block] [PATCH v7 04/15] raw: Assign bs to file in raw_co_get_block_status, Fam Zheng, 2016/01/21
- [Qemu-block] [PATCH v7 05/15] iscsi: Assign bs to file in iscsi_co_get_block_status, Fam Zheng, 2016/01/21
- [Qemu-block] [PATCH v7 06/15] parallels: Assign bs->file->bs to file in parallels_co_get_block_status, Fam Zheng, 2016/01/21
- [Qemu-block] [PATCH v7 07/15] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status, Fam Zheng, 2016/01/21
- [Qemu-block] [PATCH v7 08/15] sheepdog: Assign bs to file in sd_co_get_block_status, Fam Zheng, 2016/01/21
- [Qemu-block] [PATCH v7 09/15] vdi: Assign bs->file->bs to file in vdi_co_get_block_status, Fam Zheng, 2016/01/21
- [Qemu-block] [PATCH v7 10/15] vpc: Assign bs->file->bs to file in vpc_co_get_block_status, Fam Zheng, 2016/01/21
- [Qemu-block] [PATCH v7 11/15] vmdk: Return extent's file in bdrv_get_block_status, Fam Zheng, 2016/01/21