[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 2/4] blockdev: Fix 'change' for slot devices
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH v3 2/4] blockdev: Fix 'change' for slot devices |
|
Date: |
Mon, 25 Jan 2016 10:35:50 +0100 |
|
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Fri 22 Jan 2016 11:50:48 PM CET, Max Reitz <address@hidden> wrote:
> 'change' and related operations did not work when used on guest devices
> featuring removable media but no actual tray, because
> blk_dev_is_tray_open() always returned false for them and the
> blockdev-{insert,remove}-medium commands required it to return true.
>
> Fix this by making blockdev-{insert,remove}-medium work on tray-less
> devices. Also, blockdev-{open,close}-tray are now explicitly no-ops when
> invoked on such devices, and blk_dev_change_media_cb() is instead
> called by blockdev-{insert,remove}-medium (for tray-less devices only).
>
> Reported-by: Peter Maydell <address@hidden>
> Cc: qemu-stable <address@hidden>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-block] [PATCH v3 0/4] blockdev: Fix 'change' for slot devices, Max Reitz, 2016/01/22
- [Qemu-block] [PATCH v3 1/4] block: Add blk_dev_has_tray(), Max Reitz, 2016/01/22
- [Qemu-block] [PATCH v3 2/4] blockdev: Fix 'change' for slot devices, Max Reitz, 2016/01/22
- Re: [Qemu-block] [PATCH v3 2/4] blockdev: Fix 'change' for slot devices,
Alberto Garcia <=
- [Qemu-block] [PATCH v3 3/4] Revert "hw/block/fdc: Implement tray status", Max Reitz, 2016/01/22
- [Qemu-block] [PATCH v3 4/4] block/qapi: Emit tray_open only if there is a tray, Max Reitz, 2016/01/22
- Re: [Qemu-block] [PATCH v3 0/4] blockdev: Fix 'change' for slot devices, Kevin Wolf, 2016/01/25