[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 5/8] iotests: Make _filter_nbd drop
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 5/8] iotests: Make _filter_nbd drop log lines |
Date: |
Mon, 25 Jan 2016 13:33:06 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/25/2016 11:41 AM, Max Reitz wrote:
> The NBD log lines ("/your/source/dir/nbd.c:function():line: error")
This line doesn't match the pre- or post-patch sed pattern. Something
that would match would be "/your/source/dir/nbd/file.c:function():line:
error". Maybe you should tweak the commit message?
> should not be converted to empty lines but removed altogether.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/083.out | 10 ----------
> tests/qemu-iotests/common.filter | 2 +-
> 2 files changed, 1 insertion(+), 11 deletions(-)
> +++ b/tests/qemu-iotests/common.filter
> @@ -237,7 +237,7 @@ _filter_nbd()
> # receive callbacks sometimes, making them unreliable.
> #
> # Filter out the TCP port number since this changes between runs.
> - sed -e 's#^.*nbd/.*\.c:.*##g' \
> + sed -e '/nbd\/.*\.c:/d' \
The filter may be over-broad,...
> -e 's#nbd:127\.0\.0\.1:[^:]*:#nbd:127\.0\.0\.1:PORT:#g' \
...given that this line will be useless if anything in the resulting
message contains '.c'. A tighter filter might be worth it (maybe
'^[!:]*nbd\/[!:]*\.c:/d', to at least limit it to lines where
"nbd/...c:" appears at the front of the line? But that's a separate
change. Your conversion looks sane by itself, so:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [PATCH 1/8] nbd: client_close on error in nbd_co_client_start, (continued)
- [Qemu-block] [PATCH 2/8] iotests: Rename filter_nbd to _filter_nbd in 083, Max Reitz, 2016/01/25
- [Qemu-block] [PATCH 3/8] iotests: Change coding style of _filter_nbd in 083, Max Reitz, 2016/01/25
- [Qemu-block] [PATCH 4/8] iotests: Move _filter_nbd into common.filter, Max Reitz, 2016/01/25
- [Qemu-block] [PATCH 5/8] iotests: Make _filter_nbd drop log lines, Max Reitz, 2016/01/25
- Re: [Qemu-block] [Qemu-devel] [PATCH 5/8] iotests: Make _filter_nbd drop log lines,
Eric Blake <=
- [Qemu-block] [PATCH 6/8] iotests: Make _filter_nbd support more URL types, Max Reitz, 2016/01/25
- [Qemu-block] [PATCH 7/8] iotests: Make redirecting qemu's stderr optional, Max Reitz, 2016/01/25
- [Qemu-block] [PATCH 8/8] iotests: Add test for a nonexistent NBD export, Max Reitz, 2016/01/25
- Re: [Qemu-block] [PATCH 0/8] nbd: Fix failed assertion on negotiation error, Kevin Wolf, 2016/01/26